Re: [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.
Date: 2017-06-16 09:17:50
Message-ID: CA+OCxow65Y5yjmopyVYHfzg=kgjBdJxsrecPo5ZECVqDwRQq9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - patch applied!

On Thu, Jun 15, 2017 at 1:24 PM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch to fix #2486: Feature tests use SQLITE_PATH
> instead of TEST_SQLITE_PATH.
>
> While running the feature tests, the separate process of the app does not
> honour the config settings which are in runtests.py file.
>
> Fix:
> As per Dave, no need to set TESTING_MODE in config rather set environment
> variable PGADMIN_TESTING_MODE to check the testing status and accordingly
> set the TEST_SQLITE_PATH (i.e. Database path for testing).
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-06-16 09:21:43 Build failed in Jenkins: pgadmin4-master-python35 #177
Previous Message Dave Page 2017-06-16 09:17:42 pgAdmin 4 commit: Ensure the feature tests use the correct test setting