From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM-2859: Can't create new user |
Date: | 2017-11-24 09:51:42 |
Message-ID: | CA+OCxow3xbOTwU1YPUqprWSdguesLD5hO4atkt6s4vpYig9hJg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>
> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #2859: Can't create new user.
>>>
>>> The "User Management" dialogue footer was overlapping the back-grid
>>> table which has been fixed.
>>>
>>
>> If my screen is too small, it now looks like the attached screenshot,
>> which is really quite ugly.
>>
>> If we don't leave the bottom blank space then in case of error the
> error-message will shown on the grid itself and user can't perform any task.
> Please refer the attached screen-shot for the same.
>
Right, but we also can't have that space left blank like that. Can't we
extend the scroll range of the grid? In other words, always include space
for an extra row or so, so it can scroll above the error message, when, and
only when a message is shown?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2017-11-27 05:25:49 | Re: [pgAdmin4][Patch]: RM-2859: Can't create new user |
Previous Message | Khushboo Vashi | 2017-11-23 13:28:10 | [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key |