From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Thom Brown <thom(at)linux(dot)com> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [FEATURE] Add schema option to all relevant objects |
Date: | 2011-07-08 19:42:45 |
Message-ID: | CA+OCxow2eAFyMTkxS66s2bfqKu3e6TNygyHZYyP=4F3YLaZtRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Friday, July 8, 2011, Thom Brown <thom(at)linux(dot)com> wrote:
> On 8 July 2011 20:15, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>> * all extension changes are wrong according to me because they aren't
>>>> schema objects, but database objects. I don't keep them.
>>>
>>> The reason why I based it on schema is because I wanted it to inherit
>>> the schema combobox object and its source for a list of schemas so
>>> lots of redundant code could be removed. There should be no
>>> functional difference, but I'm probably missing the point here. :)
>>
>> It's a misuse of the class, because it's intended to represent the
>> schema the object is in, not one it's related to in some other way.
>> We've made the mistake of trying to use these classes in ways that
>> weren't intended in the past, and it's bitten us badly. I'm not keen
>> to repeat that, for the sake of a few lines of code to store a schema
>> name,
>
> Whilst I don't see the actual impact, I'll concede the point since
> I've only just started looking at code really so wouldn't have seen
> the issue first-hand. Extensions are a weird case for me since you
> can assign them to a schema, but they are immune to being hidden by
> the search path.
Think of an extension as 2 things - the packaging, and the contents.
The packaging is what we show under the Database node - it doesn't
have a schema. The contents do have a schema, and the packaging
mechanism gives you a simple way to change it.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-07-08 19:50:55 | pgAdmin III commit: Beautify SQL code for comments and owners |
Previous Message | Thom Brown | 2011-07-08 19:36:10 | Re: [FEATURE] Add schema option to all relevant objects |