Re: [pgAdmin][RM5348]LDAP Authentication Support

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Abhilasha Narendra <abhilasha(dot)narendra(at)enterprisedb(dot)com>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5348]LDAP Authentication Support
Date: 2020-04-27 13:38:51
Message-ID: CA+OCxow2FVwDG+nSZPCL_Vx1mY=-ej1DFMaSQq3+Y2Hi1-EhiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

My point is that we should be consistent. If we add detailed docs for those
config parameters, let's add them for everything (not necessarily today or
this release of course).

I do agree with Akshay that this may work better as a table.

It shouldn't hold up the release though.

On Mon, Apr 27, 2020 at 2:18 PM Abhilasha Narendra <
abhilasha(dot)narendra(at)enterprisedb(dot)com> wrote:

> Currently, the config.py file doesn’t have detailed information about the
> parameters. Do we need to update that file to include the detailed
> information?
>
> Regards,
> Abhilasha
>
>
> On 27-Apr-2020, at 6:39 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
> Hi Dave
>
> On Mon, Apr 27, 2020 at 6:23 PM Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Akshay,
>>
>> I'm not sure that should even be there. We document other config options
>> in the default file and import that into the docs don't we?
>>
>
> Yes, we have all the config options in the default file(config.py). But
> the end-user need some reference in the documentation about LDAP, we can do
> one thing to provide the link of the config.py as a reference for the
> parameters. Please check the below screenshot what I am suggesting:
> <Screenshot 2020-04-27 at 6.31.57 PM.png>
>
>
>> On Mon, Apr 27, 2020 at 1:51 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave/Abhilasha
>>>
>>> I have checked the documentation, can we have LDAP parameter in tabular
>>> format for more readability. Below is the screenshot of the current view in
>>> browser:
>>>
>>> <LDAP_Parameters.png>
>>>
>>>
>>> On Mon, Apr 27, 2020 at 5:59 PM Abhilasha Narendra <
>>> abhilasha(dot)narendra(at)enterprisedb(dot)com> wrote:
>>>
>>>> PFA the updated patch.
>>>>
>>>> Regards,
>>>> Abhilasha
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On 27-Apr-2020, at 5:41 PM, Abhilasha Narendra <
>>>> abhilasha(dot)narendra(at)enterprisedb(dot)com> wrote:
>>>>
>>>> Apologies for missing the file.
>>>>
>>>> PFA the updated patch.
>>>>
>>>> Regards,
>>>> Abhilasha
>>>>
>>>>
>>>>
>>>> <rm5348.patch>
>>>>
>>>>
>>>>
>>>>
>>>> On 27-Apr-2020, at 5:38 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>> Hi Abhilasha
>>>>
>>>> Getting below error:
>>>>
>>>> Warning, treated as error:
>>>> /Users/akshayjoshi/Developement/pgAdmin4/docs/en_US/getting_started.rst:31:toctree
>>>> contains reference to nonexisting document ‘enabling_ldap_authentication’
>>>>
>>>> I think you forgot to add ‘enabling_ldap_authentication’ file in the
>>>> patch.
>>>>
>>>>
>>>> On Mon, Apr 27, 2020 at 3:36 PM Abhilasha Narendra <
>>>> abhilasha(dot)narendra(at)enterprisedb(dot)com> wrote:
>>>>
>>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> I have updated the documentation for LDAP authentication support in
>>>>> pgAdmin.
>>>>>
>>>>> PFA the patch.
>>>>>
>>>>> Regards,
>>>>> Abhilasha
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>>
>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> VP & Chief Architect, Database Infrastructure
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
>
>

--
Dave Page
VP & Chief Architect, Database Infrastructure
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-04-27 14:00:51 [pgAdmin][RM5441] Not able to find path toast tables under pg_toast schema
Previous Message Akshay Joshi 2020-04-27 13:23:52 Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.