Re: pgAdmin crashes when checking "Security of definer"

On Mon, Nov 26, 2012 at 8:08 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Sun, 2012-11-25 at 14:47 +0000, Dave Page wrote:
>> On Sunday, November 25, 2012, Guillaume Lelarge wrote:
>>
>> > On Fri, 2012-11-23 at 00:22 +1100, Evan Martin wrote:
>> > > The Apply button is disabled when I open function properties. It only
>> > > becomes enabled when I make a change. You're right, this is not
>> > > exclusive to "Security of definer" - any change will do. For example, I
>> > > can change the function cost, click Apply (the button becomes disabled
>> > > again), then as soon as I press a digit key with the cursor in the
>> > > function cost textbox pgAdmin crashes.
>> > >
>> > > For me this is reproducible every time.
>> > >
>> >
>> > I reproduce it too. Working on it.
>> >
>>
>> I was looking at this earlier too, and could also reproduce it. It looks
>> like the pointer to the pgFunction object that the dialogue holds becomes
>> invalid, presumably when the tree item is refeshed. I'm guessing this
>> applies to all dialogues with Apply buttons - not sure when or how it got
>> broken though.
>>
>
> My guess would be when we added the automatic refresh of the tree. But I
> didn't get any further.

Nope - it was the code to prevent an object being dropped if the
properties dialogue for it is open. Akshay figured out a fix, and I've
pushed it to master and REL-1_16_0_PATCHES.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company