Re: remaining sql/json patches

On Fri, Nov 17, 2023 at 4:27 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> hi.
> minor issues.

Thanks for checking.

> In transformJsonFuncExpr(ParseState *pstate, JsonFuncExpr *func)
> func.behavior->on_empty->location and
> func.behavior->on_error->location are correct.
> but in ExecInitJsonExpr, jsestate->jsexpr->on_empty->location is -1,
> jsestate->jsexpr->on_error->location is -1.
> Maybe we can preserve these on_empty, on_error token locations in
> transformJsonBehavior.

Sure.

> some enum declaration, ending element need an extra comma?

Didn't know about the convention to have that comma, but I can see it
is present in most enum definitions.

Changed all enums that the patch adds to conform.

> + /*
> + * ExecEvalJsonExprPath() will set this to the address of the step to
> + * use to coerce the result of JsonPath* evaluation to the RETURNING
> + * type. Also see the description of possible step addresses this
> + * could be set to in the definition of JsonExprState.ZZ
> + */
>
> "ZZ", typo?

Indeed.

Will include the fixes in the next version.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com