Re: pgsql: Improve handling of inherited GENERATED expressions.

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Improve handling of inherited GENERATED expressions.
Date: 2023-01-13 02:52:50
Message-ID: CA+HiwqHbYAxj7Ns4u=Jn1Apw+=_f+ixcwJV+DtAjWBkXqFESyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jan 13, 2023 at 6:41 Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

>
> On 2023-01-12 Th 15:44, Tom Lane wrote:
> > I wrote:
> >> Yeah. I think best bet may be to drop the problematic table(s),
> >> as we've done for other de-supported DDL situations. A quick
> >> experiment suggests that
> >> DROP TABLE gtest_normal_child;
> >> DROP TABLE gtest_normal_child2;
> >> should do it.
> > Some testing here confirms that the attached patch is enough to
> > un-break things for HEAD. Since you mentioned you have some other
> > quasi-urgent BF fixes, maybe the thing to do is to roll up a release
> > now and then work on the bigger idea at leisure.
> >
> >
>
>
> Thanks, that's almost exactly what I did to turn crake green.
>
> I'll push out a release tomorrow.

Thanks to both of you.

> --
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-01-13 03:13:45 pgsql: Avoid creating parallel apply state hash table unless required.
Previous Message Michael Paquier 2023-01-13 01:35:43 pgsql: Add tests for regex replacement with \1 in pg_ident.conf to 0003