| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | obsolete reference to a SubPlan field |
| Date: | 2022-02-02 08:07:39 |
| Message-ID: | CA+HiwqHaOx5+V7x7V3H8sWn=Mz0j4q4ZAkM+YtAikTzczkSe6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed $subject while looking at something involving SubLinks and
SubPlans. It seems eab6b8b27eb removed the "plan" field from the
SubPlan node struct definition, but the following line from
expression_tree_mutator():
/* but not the sub-Plan itself, which is referenced as-is */
and the following from expression_tree_walker():
/* recurse into the testexpr, but not into the Plan */
both of which I think refer to that no-longer-existent field, appear
to have survived multiple commits that moved the SubPlan expression
processing code around.
Attached patch removes those.
--
Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| SubPlan-obsolete-comment.patch | application/octet-stream | 833 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-02-02 08:29:57 | Re: Plug minor memleak in pg_dump |
| Previous Message | Kyotaro Horiguchi | 2022-02-02 08:04:21 | Re: RFC: Logging plan of the running query |