Re: no default hash partition

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: no default hash partition
Date: 2019-08-08 01:01:38
Message-ID: CA+HiwqHVGoZx=LOdwMdhARn7L7-0xcYswhyW-s8cFvnqS==ctA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 8, 2019 at 6:22 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On 2019-Aug-07, Tom Lane wrote:
> >> Hm, that's rather confusingly worded IMO. Is the antecedent of "this
> >> option" just DEFAULT, or does it mean that you can't use FOR VALUES,
> >> or perchance it means that you can't use a PARTITION OF clause
> >> at all?
>
> > Uh, you're right, I hadn't noticed that. Not my text. I think this can
> > be fixed easily as in the attached. There are other options, but I like
> > this one the best.
>
> OK, but maybe also s/created as a default partition/created as the default
> partition/ ? Writing "a" carries the pretty clear implication that there
> can be more than one, and contradicting that a sentence later doesn't
> improve it.

+1. Maybe also remove the last sentence of the 2nd paragraph, that
is, this one:

There can be only one default partition for a given parent table.

Regards,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-08-08 01:10:11 Re: partition routing layering in nodeModifyTable.c
Previous Message Alexander Korotkov 2019-08-08 00:27:38 Re: SQL/JSON path: collation for comparisons, minor typos in docs