| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH] use separate PartitionedRelOptions structure to store partitioned table options |
| Date: | 2019-10-10 05:58:50 |
| Message-ID: | CA+HiwqHPjHi1p0ieBtp7n_5H83y90Ns1ZWQoW1cOcPS+bCkpiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On Tue, Oct 8, 2019 at 7:50 PM Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
> В письме от вторник, 8 октября 2019 г. 16:00:49 MSK пользователь Amit Langote
> написал:
> > IIUC, this patch invents PartitionedRelOptions as the binary
> > representation for future RELOPT_KIND_PARTITIONED parameters. As long
> > as others are on board with using different *Options structs for
> > different object kinds, I see no problem with this idea.
> Yes, this is correct. Some Access Methods already use it's own Options
> structure. As far as I can guess StdRdOptions still exists only for historical
> reasons, and became quite a mess because of adding all kind of stuff there.
> Better to separate it.
>
> BTW, as far as you are familiar with this part of the code, may be you will
> join the review if this particular patch?
Sure, I will try to check your patch.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-10-10 06:28:45 | Re: adding partitioned tables to publications |
| Previous Message | Amit Langote | 2019-10-10 05:56:32 | Re: dropping column prevented due to inherited index |