| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Japin Li <japinli(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Forget close an open relation in ReorderBufferProcessTXN() |
| Date: | 2021-06-01 12:04:38 |
| Message-ID: | CA+HiwqHLKrZ4XcZ7kpwwQSM4L2Lwg_0T2O6-D=r+T195a8oNLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 1, 2021 at 6:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, May 31, 2021 at 8:51 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > On Thu, May 27, 2021 at 3:36 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > Why do we need to move send_relation_and_attrs() call? I think it
> > > doesn't matter much either way but OTOH, in the existing code, if
> > > there is an error (say 'out of memory' or some other) while building
> > > the map, we won't send relation attrs whereas with your change we will
> > > unnecessarily send those in such a case.
> >
> > That's a good point. I've reverted that change in the attached.
>
> Pushed.
Thank you.
--
Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-06-01 12:15:08 | Re: storing an explicit nonce |
| Previous Message | Amit Langote | 2021-06-01 11:55:42 | parent foreign tables and row marks |