From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: making update/delete of inheritance trees scale better |
Date: | 2020-10-29 13:03:33 |
Message-ID: | CA+HiwqH8MrBQ-Jm+h3YpYL6U4SuMxNE7oqe00iYRvVddYs-bLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Oct 4, 2020 at 11:44 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Fri, Sep 11, 2020 at 7:20 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Here are the commit messages of the attached patches:
> >
> > [PATCH v3 1/3] Overhaul how updates compute a new tuple
>
> I tried to assess the performance impact of this rejiggering of how
> updates are performed. As to why one may think there may be a
> negative impact, consider that ExecModifyTable() now has to perform an
> extra fetch of the tuple being updated for filling in the unchanged
> values of the update's NEW tuple, because the plan itself will only
> produce the values of changed columns.
>
...
> It seems clear that the saving on the target list computation overhead
> that we get from the patch is hard to ignore in this case.
>
> I've attached updated patches, because as Michael pointed out, the
> previous version no longer applies.
Rebased over the recent executor result relation related commits.
--
Amit Langote
EDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Overhaul-how-updates-compute-a-new-tuple.patch | application/octet-stream | 76.2 KB |
v5-0002-Revise-how-inherited-update-delete-are-handled.patch | application/octet-stream | 199.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2020-10-29 13:04:45 | Re: partition routing layering in nodeModifyTable.c |
Previous Message | John Naylor | 2020-10-29 12:54:07 | Re: document pg_settings view doesn't display custom options |