Re: Incorrect matching of sql/json PASSING variable names

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect matching of sql/json PASSING variable names
Date: 2024-06-19 06:52:12
Message-ID: CA+HiwqH4-cWBhn-6OaBk2QmzV+8MocW6EBYydMLfaF+R1J24kQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 13, 2024 at 5:04 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Jun 6, 2024 at 6:20 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > Alvaro reported off-list that the following should really fail,
> > because the jsonpath expression refers to a PASSING variable that
> > doesn't exist:
> >
> > select json_query('"1"', jsonpath '$xy' passing 2 AS xyz);
> > json_query
> > ------------
> > 2
> > (1 row)
> >
> > This works because of a bug in GetJsonPathVar() whereby it allows a
> > jsonpath expression to reference any prefix of the PASSING variable
> > names.
> >
> > Attached is a patch to fix that.
>
> Here's an updated version that I'll push tomorrow.

Pushed.

(Seems like pgsql-committers notification has stalled.)

--
Thanks, Amit Langote

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2024-06-19 06:54:02 Re: ON ERROR in json_query and the like
Previous Message Li, Yong 2024-06-19 06:44:58 Re: Separate HEAP WAL replay logic into its own file