From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Markus Winand <markus(dot)winand(at)winand(dot)at> |
Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ON ERROR in json_query and the like |
Date: | 2024-06-22 08:43:05 |
Message-ID: | CA+HiwqH1wXJnASrhXcijzqMx6sKznXbE093E6MUBPQGDR2ifwQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thanks all for chiming in.
On Fri, Jun 21, 2024 at 8:00 PM Markus Winand <markus(dot)winand(at)winand(dot)at> wrote:
> So updating the three options:
> > 1. Disallow anything but jsonb for context_item (the patch I posted yesterday)
>
> * Non-conforming
> * patch available
>
> > 2. Continue allowing context_item to be non-json character or utf-8
> > encoded bytea strings, but document that any parsing errors do not
> > respect the ON ERROR clause.
>
> * Conforming by choosing IA050 to implement GR4: raise errors independent of the ON ERROR clause.
> * currently committed.
>
> > 3. Go ahead and fix implicit casts to jsonb so that any parsing errors
> > respect ON ERROR (no patch written yet).
>
> * Conforming by choosing IA050 not to implement GR4: Parsing happens later, considering the ON ERROR clause.
> * no patch available, not trivial
>
> I guess I’m the only one in favour of 3 ;) My remaining arguments are that Oracle and Db2 (LUW) do it that way and also that it is IMHO what users would expect. However, as 2 is also conforming (how could I miss that?), proper documentation is a very tempting option.
So, we should go with 2 for v17, because while 3 may be very
appealing, there's a risk that it might not get done in the time
remaining for v17.
I'll post the documentation patch on Monday.
--
Thanks, Amit Langote
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Lakhin | 2024-06-22 09:00:00 | recoveryCheck/008_fsm_truncation is failing on dodo in v14- (due to slow fsync?) |
Previous Message | Amit Langote | 2024-06-22 08:31:50 | Re: SQL/JSON query functions context_item doc entry and type requirement |