Re: pgsql: Add isolation tests for snapshot behavior in ri_triggers.c

Hi Alvaro,

On Fri, Apr 8, 2022 at 3:32 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Add isolation tests for snapshot behavior in ri_triggers.c
>
> They are to check the behavior of RI_FKey_check() and
> ri_Check_Pk_Match(). A test case whereby RI_FKey_check() queries a
> partitioned PK table under REPEATABLE READ isolation produces wrong
> output due to a bug of the partition-descriptor logic and that is noted
> as such in the comment in the test. A subsequent commit will fix the
> bug and replace the buggy output by the correct one.

Should this one also have been reverted? I wonder if it might be
better to add this suite with the (yet unwritten) patch to fix the bug
mentioned in the above commit message, which will likely be
back-ported.

--
Amit Langote
EDB: http://www.enterprisedb.com