Re: ModifyTable overheads in generic plans

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com
Subject: Re: ModifyTable overheads in generic plans
Date: 2020-07-01 13:38:45
Message-ID: CA+HiwqGn4+1pOPusfAA6t__8pAjnJAQ=1Y348hH_np0dce-8yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Daniel,

On Wed, Jul 1, 2020 at 6:50 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 1 Jul 2020, at 08:30, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> > On Fri, Jun 26, 2020 at 9:36 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >> I would like to discuss a refactoring patch that builds on top of the
> >> patches at [1] to address $subject.
> >
> > I forgot to update a place in postgres_fdw causing one of its tests to crash.
> >
> > Fixed in the attached updated version.
>
> The attached 0003 fails to apply to current HEAD, please submit another rebased
> version. Marking the entry as Waiting on Author in the meantime.

Thank you for the heads up.

Actually, as I noted in the first email, the patches here are to be
applied on top of patches of another thread that I chose not to post
here. But I can see how that is inconvenient both for the CF bot and
other humans, so I'm attaching all of the patches.

Another thing I could do is decouple the patches to discuss here from
the patches of the other thread, which should be possible and might be
good to avoid back and forth between the two threads.

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v2-0005-Delay-initializing-UPDATE-DELETE-ResultRelInfos.patch application/octet-stream 67.2 KB
v2-0003-Revise-how-some-FDW-executor-APIs-obtain-ResultRe.patch application/octet-stream 10.5 KB
v2-0004-Do-not-set-rootResultRelIndex-unnecessarily.patch application/octet-stream 1.3 KB
v2-0001-Overhaul-UPDATE-s-targetlist-processing.patch application/octet-stream 74.3 KB
v2-0002-Overhaul-how-inherited-update-delete-are-handled.patch application/octet-stream 185.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-07-01 13:42:57 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Robert Haas 2020-07-01 13:36:42 Re: SQL-standard function body