| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
| Subject: | Re: ModifyTable overheads in generic plans |
| Date: | 2020-12-07 06:53:37 |
| Message-ID: | CA+HiwqGgP0OLhHkZcNN9GJjNqkY3P66776XzG_fLzKFNfYeg-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 12, 2020 at 5:04 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Attached new 0002 which does these adjustments. I went with
> ri_RootTargetDesc to go along with ri_RelationDesc.
>
> Also, I have updated the original 0002 (now 0003) to make
> GetChildToRootMap() use ri_RootTargetDesc instead of
> ModifyTableState.rootResultRelInfo.ri_RelationDesc, so that even
> AfterTriggerSaveEvent() can now use that function. This allows us to
> avoid having to initialize ri_ChildToRootMap anywhere but inside
> GetChildRootMap(), with that long comment defending doing so. :-)
These needed to be rebased due to recent copy.c upheavals. Attached.
--
Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Set-ForeignScanState.resultRelInfo-lazily.patch | application/octet-stream | 4.1 KB |
| v11-0002-Rethink-ResultRelInfo.ri_PartitionRoot.patch | application/octet-stream | 26.7 KB |
| v11-0003-Initialize-result-relation-information-lazily.patch | application/octet-stream | 52.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | k.jamison@fujitsu.com | 2020-12-07 07:02:35 | RE: [Patch] Optimize dropping of relation buffers using dlist |
| Previous Message | Craig Ringer | 2020-12-07 06:09:35 | Re: POC: Better infrastructure for automated testing of concurrency issues |