From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Wired if-statement in gen_partprune_steps_internal |
Date: | 2020-10-20 12:46:44 |
Message-ID: | CA+HiwqGd5f++NJnrmqAkUhsuMEa4APpeyCox46aYzVXadOqrwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Andy,
On Tue, Oct 20, 2020 at 4:05 PM Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> wrote:
> On Wed, Oct 14, 2020 at 11:26 AM Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> wrote:
>> On Mon, Oct 12, 2020 at 4:37 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>>> I think we should remove this duplicative logic and return the
>>> generated steps in a list from this function, which the code in
>>> gen_partprune_steps_internal() then "combines" using an INTERSECT
>>> step. See attached a patch to show what I mean.
>>>
>>
>> This changes LGTM, and "make check" PASSED, thanks for the patch!
>>
>
> I created https://commitfest.postgresql.org/30/2771/ so that this patch will not
> be lost. Thanks!
Thanks for doing that.
I had updated the patch last week to address Horiguchi-san's comments
but didn't manage to post a polished-enough version. I will try again
this week.
--
Amit Langote
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2020-10-20 12:55:37 | Re: Make procedure OUT parameters work with JDBC |
Previous Message | Dilip Kumar | 2020-10-20 12:29:39 | Re: Is Recovery actually paused? |