Re: Fix a typo in rewriteHandler.c

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: "Sho Kato (Fujitsu)" <kato-sho(at)fujitsu(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in rewriteHandler.c
Date: 2023-06-16 01:25:13
Message-ID: CA+HiwqGGvzi=iF4G4wshr1emHdNaYQbQfxZEQ5vVZxo68BbvEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On Thu, Jun 15, 2023 at 5:07 PM Sho Kato (Fujitsu) <kato-sho(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> I've attached the patch for the following rewriteTargetView comments.
>
>
> Assert(parsetree->resultRelation == new_rt_index);
>
> /*
> * For INSERT/UPDATE we must also update resnos in the targetlist to refer
> * to columns of the base relation, since those indicate the target
> * columns to be affected.
> *
> * Note that this destroys the resno ordering of the targetlist, but that
> * will be fixed when we recurse through rewriteQuery, which will invoke
> * rewriteTargetListIU again on the updated targetlist.
> */
> if (parsetree->commandType != CMD_DELETE)
> {
> foreach(lc, parsetree->targetList)
>
> s/rewriteQuery/RewriteQuery

Good catch and thanks for the patch. Will push shortly.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message YANG Xudong 2023-06-16 01:28:07 Re: [PATCH] Add loongarch native checksum implementation.
Previous Message Joel Jacobson 2023-06-16 00:27:33 Re: Do we want a hashset type?