Re: generic plans and "initial" pruning

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: generic plans and "initial" pruning
Date: 2025-02-12 11:53:50
Message-ID: CA+HiwqGGLDTd1ZTK1c0zv4La7XOVSVMqBuNtscJeh6FyUQvFvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 6, 2025 at 11:35 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Per cfbot-ci, the new test case output in 0002 needed to be updated.
>
> I plan to push 0001 tomorrow, barring any objections.

I pushed that last Friday. With bb3ec16e, d47cbf47, and cbc12791 now in:

* Pruning information is now stored separately from parent plan nodes
in PlannedStmt.

* Initial runtime pruning occurs as a separate step, independent of
and before plan initialization in InitPlan().

* The RT indexes of unprunable relations and those of partitions that
survive initial pruning are stored in a global bitmapset in EState,
allowing us to avoid work that was previously done for pruned
partitions. This was difficult before because initial pruning wasn’t
performed before the parent plan node was initialized, meaning that
the work we aimed to save had already been done.

The final remaining piece is to skip taking locks on partitions pruned
during initial pruning, and the attached patch addresses that.

I’d like to commit the patch next week, barring objections.

--
Thanks, Amit Langote

Attachment Content-Type Size
v63-0001-Don-t-lock-partitions-pruned-by-initial-pruning.patch application/x-patch 88.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-02-12 12:41:22 Re: NOT ENFORCED constraint feature
Previous Message Amit Kapila 2025-02-12 11:52:47 Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary