Re: BUG #18657: Using JSON_OBJECTAGG with volatile function leads to segfault

On Wed, Oct 16, 2024 at 5:20 PM Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> Amit Langote <amitlangote09(at)gmail(dot)com> 于2024年10月16日周三 08:35写道：
>>
>> On Wed, Oct 16, 2024 at 9:19 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> > On Tue, Oct 15, 2024 at 11:00:01AM +0000, PG Bug reporting form wrote:
>> > > First bad commit for this anomaly is b6e1157e7.
>> >
>> > Amit, any thoughts?
>>
>> Will look into it, thanks.
> Hi,
>
> I debug this issue, and I find that:
> after b6e1157e7, we shouldn't walk JsonValueExpr.raw_expr in expression_tree_walker_impl(), which
> is called in preprocess_aggrefs().
>
> I try to above solution, no crashed again.

Thanks for the analysis. That is my conclusion as well.

Attached a patch.

--
Thanks, Amit Langote