Re: generic plans and "initial" pruning

On Wed, Dec 4, 2024 at 10:34 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> I'll post the updated patches tomorrow.

Here is an updated set.

I said that Assert suffices in ExecInitPartitionPruning() but on
further thought and after finding the following in ExecInitExprRec()
that an elog() won't hurt.

/* planner messed up */
elog(ERROR, "Aggref found in non-Agg plan node");

Like this:

+ /* Obtain the pruneinfo we need. */
+ pruneinfo = list_nth_node(PartitionPruneInfo, estate->es_part_prune_infos,
+ part_prune_index);
+
+ /* Its relids better match the plan node's or the planner messed up. */
+ if (!bms_equal(relids, pruneinfo->relids))
+ elog(ERROR, "wrong pruneinfo with relids=%s found at
part_prune_index=%d contained in plan node with relids=%s",
+ bmsToString(pruneinfo->relids), part_prune_index,
+ bmsToString(relids));

I've merged what were 0004 and 0005 in v57 together because they would
be eventually committed together and I wanted to write a unified
commit message.

One notable change is that I've renamed ExecutorStartExt() to
ExecutorStartCachedPlan() and changed its callers to only call it if a
CachedPlan is available, calling ExecutorStart() otherwise.

I'm still looking at Tomas's perf numbers and haven't confirmed some
of the findings myself.

--
Thanks, Amit Langote