Re: problem with RETURNING and update row movement

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: problem with RETURNING and update row movement
Date: 2021-03-22 08:33:33
Message-ID: CA+HiwqFqhQtKDvXFirBFOZoEQJRLHAD=--M4_wrV3HwWfGie-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 6, 2021 at 12:52 AM David Steele <david(at)pgmasters(dot)net> wrote:
> On 10/30/20 6:00 AM, Amit Langote wrote:
> > The question
> > I guess is whether that thread must conclude before the fix here can
> > be committed.
>
> Indeed. But it seems like there is a candidate patch on [1] though that
> thread has also stalled. I'll try to get some status on that thread but
> the question remains if this patch will be stalled until [1] is resolved.

Sorry for the delay in following up on this thread. I've posted new
patches on the other.

FWIW, I think we should go ahead and apply the patches for the bug
reported here. Anyone who tries to project an updated tuple's system
columns using RETURNING are likely to face problems one way or
another, especially if they have partitioned tables containing
partitions of varying table AMs, but at least they won't face the bug
discussed here.

I've attached patches for all affected branches.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v7-0001-Fix-a-bug-with-RETURNING-when-UPDATE-moves-tuple-HEAD.patch application/octet-stream 12.3 KB
v7-0001-Fix-a-bug-with-RETURNING-when-UPDATE-moves-tuple-PG12.patch application/octet-stream 10.5 KB
v7-0001-Fix-a-bug-with-RETURNING-when-UPDATE-moves-tuple-PG11.patch application/octet-stream 10.2 KB
v7-0001-Fix-a-bug-with-RETURNING-when-UPDATE-moves-tuple-PG13.patch application/octet-stream 10.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Juan José Santamaría Flecha 2021-03-22 08:36:46 Re: [PATCH] Bug fix in initdb output
Previous Message Amul Sul 2021-03-22 08:25:23 Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb