Re: pg_dump emits ALTER TABLE ONLY partitioned_table

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: 2017-05-04 04:14:31
Message-ID: CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Stephen,

On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Amit,
>
> * Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
>> Attached updated patches.
>
> Please find an updated version which corrects the issue with
> binary-upgrade of partitioned tables having partitions in other schemas,
> along with a few other minor improvements.
>
> If you could take a look at it, I'd appreciate it. We already had a
> test case in the pg_dump TAP tests for partitions existing in a schema
> different from the partitioned table, but we weren't checking the
> binary-upgrade case, so I've added a check to do that now. I'm sure
> additional tests would be good to add and will take a look at doing that
> tomorrow, but this hopefully closes at least the latest issue.
>
> Assuming this looks good to you, I'll push it tomorrow, possibly with
> other minor adjustments and perhaps a few more tests.

Your latest patch looks good to me.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-05-04 04:19:04 Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Previous Message Tom Lane 2017-05-04 03:43:43 Reducing runtime of stats regression test