Re: TOAST table created for partitioned tables

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TOAST table created for partitioned tables
Date: 2018-01-17 06:03:24
Message-ID: CA+HiwqFkOLojaEWZBBepq3qSrjEj8saCBMii4E9dPtLfAA4G6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 17, 2018 at 1:51 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Jan 16, 2018 at 11:38:58PM -0500, Tom Lane wrote:
>> Yeah, pg_upgrade already has to cope with cases where the newer version
>> thinks a table needs a toast table when the older version didn't, or
>> vice versa. This looks like it ought to fall into that category.
>> Not that testing it wouldn't be a good idea.
>
> As far as I can see this statement is true. If you create a parent
> partition table in a v10 cluster, and then upgrade to HEAD with this
> patch applied, you'll be able to notice that the relation still has its
> toast table present, while newly-created parent partitions would have
> nothing. (Just tested, I didn't review the patch in details).

Thanks for checking. I too checked that pg_upgrading v10 cluster
containing partitioned tables that have a TOAST table attached to it
works normally and like Michael says, the TOAST table remains.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-01-17 06:14:01 Re: [Sender Address Forgery]Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning
Previous Message Jeff Davis 2018-01-17 05:49:15 Re: Rangejoin rebased