Re: pg_trigger.tgparentid

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_trigger.tgparentid
Date: 2020-02-25 14:57:55
Message-ID: CA+HiwqFhk_jBAd6rqBY45LZBbTOhNaZg-7PHWeqZF7DCKSPd7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 25, 2020 at 11:01 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> On 2020-Feb-25, Amit Langote wrote:
> > On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > > Thanks for pointing this out -- I agree it needed rewording. I slightly
> > > adjusted your text like this:
> > >
> > > * Internal triggers require careful examination. Ideally, we don't
> > > * clone them. However, if our parent is itself a partition, there
> > > * might be internal triggers that must not be skipped; for example,
> > > * triggers on our parent that are in turn clones from its parent (our
> > > * grandparent) are marked internal, yet they are to be cloned.
> > >
> > > Is this okay for you?
> >
> > Thanks. Your revised text looks good, except there is a typo:
> >
> > in turn clones -> in turn cloned
>
> Actually, that was on purpose ... (I also changed "were" to "are" to match.)

Ah, got it.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2020-02-25 15:31:09 Re: [Proposal] Global temporary tables
Previous Message Asif Rehman 2020-02-25 14:34:35 Re: [Patch] Base backups and random or zero pageheaders