From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: set relispartition when attaching child index |
Date: | 2019-04-24 15:39:52 |
Message-ID: | CA+HiwqFJViPKwQ-WxstxqOwNEBXte+ApdzJ=ab5-h6tLOogdzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Apr 25, 2019 at 12:38 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Apr 25, 2019 at 12:35 AM Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > On 2019-Apr-25, Amit Langote wrote:
> >
> > > It seems that DefineIndex() is forgetting to update_relispartition()
> > > on a partition's index when it's attached to an index being added to
> > > the parent. That results in unexpected behavior when adding a foreign
> > > key referencing the parent.
> >
> > BTW, maybe IndexSetParentIndex ought to be the one calling
> > update_relispartition() ...
>
> I thought so too, but other sites are doing what I did in the patch.
Although, we wouldn't have this bug if it was IndexSetParentIndex
calling it. Maybe a good idea to do that now.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2019-04-24 15:55:31 | Re: set relispartition when attaching child index |
Previous Message | Amit Langote | 2019-04-24 15:38:02 | Re: set relispartition when attaching child index |