| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, sbernikov(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |
| Date: | 2021-06-11 07:30:03 |
| Message-ID: | CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jun 11, 2021 at 3:26 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Jun 11, 2021 at 02:56:58PM +0900, Amit Langote wrote:
> > Attached fixes the problem for me. Not sure if adding a test case makes sense.
>
> It seems to me that it would make sense to have some coverage. We've
> caught issues in the past in this area, particularly with buildfarm
> animals running CLOBBER_CACHE_ALWAYS.
I thought about it for a minute when writing the patch I posted, but
wasn't really sure what the test case would look like. The only
external proof that the case worked correctly, AFAICS, is the DEBUG1
message that's written to the log. How do we add a test case with
that? I know you mentioned an idea before to check/grep the log for
such cases. Is that how?
--
Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-11 15:01:07 | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |
| Previous Message | Michael Paquier | 2021-06-11 06:26:28 | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |