From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL |
Date: | 2019-09-17 09:58:32 |
Message-ID: | CA+HiwqEaM2tV5awKhP1vSbgjQe_uXVU15Oi4sTgwgempwMiT8g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Hi Alvaro,
On Sat, Sep 14, 2019 at 2:59 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> Fix progress reporting of CLUSTER / VACUUM FULL
>
> The progress state was being clobbered once the first index completed
> being rebuilt, causing the final phases of the operation not show
> anything in the progress view. This was inadvertently broken in
> 03f9e5cba0ee, which added progress tracking for REINDEX.
I noticed that the progress of REINDEX INDEX index_name is no longer
shown; REINDEX TABLE table_name is fine. Maybe you missed updating
ReindexIndex() to pass the option to report progress, like this:
@@ -2350,7 +2350,8 @@ ReindexIndex(RangeVar *indexRelation, int
options, bool concurrent)
if (concurrent)
ReindexRelationConcurrently(indOid, options);
else
- reindex_index(indOid, false, persistence, options);
+ reindex_index(indOid, false, persistence,
+ options | REINDEXOPT_REPORT_PROGRESS);
}
Attached a patch.
Thanks,
Amit
Attachment | Content-Type | Size |
---|---|---|
ReindexIndex-progress-option.patch | application/octet-stream | 515 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-17 19:40:01 | pgsql: Fix bogus handling of XQuery regex option flags. |
Previous Message | Peter Eisentraut | 2019-09-17 09:45:00 | pgsql: Remove mingwcompat.c |