Re: pgsql: Centralize json and jsonb handling of datetime types

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Centralize json and jsonb handling of datetime types
Date: 2018-01-17 09:10:50
Message-ID: CA+HiwqEO+oisVGbBXEEp=TvLzbu2C5vGDBwSOwt4XOCcJiLsaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Jan 17, 2018 at 5:34 PM, Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>
>
> On 01/17/2018 12:34 AM, Amit Langote wrote:
>> On Wed, Jan 17, 2018 at 9:29 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> Centralize json and jsonb handling of datetime types
>> [ ... ]
>>
>>> src/include/utils/date.h | 4 +-
>> I noticed that these changes cause the following warning to be emitted
>> when compiling with gcc (GCC) 6.2.0:
>>
>> Attached is a fix.
>>
>
> Thanks, this is the right fix but in the wrong place. I have added the
> include in the file where pg_tm is actually used.

Thank you.

Regards,
Amit

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2018-01-17 11:42:23 pgsql: Ability to advance replication slots
Previous Message Andrew Dunstan 2018-01-17 08:34:52 Re: pgsql: Centralize json and jsonb handling of datetime types

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-01-17 09:19:45 Re: [Sender Address Forgery]Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning
Previous Message Etsuro Fujita 2018-01-17 09:02:49 Re: [HACKERS] postgres_fdw bug in 9.6