| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: enable/disable broken for statement triggers on partitioned tables |
| Date: | 2022-05-27 12:23:08 |
| Message-ID: | CA+HiwqE99dV3NHW6ATcA-KOWG0vxV8_=-qNYdFGyc7GxTNanYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 27, 2022 at 5:11 PM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> On 24.05.22 23:23, Zhihong Yu wrote:
> > Hi,
> >
> > AT_EnableTrig, /* ENABLE TRIGGER name */
> > + AT_EnableTrigRecurse, /* internal to commands/tablecmds.c */
> > AT_EnableAlwaysTrig, /* ENABLE ALWAYS TRIGGER name */
> > + AT_EnableAlwaysTrigRecurse, /* internal to commands/tablecmds.c */
> >
> > Is it better to put the new enum's at the end of the AlterTableType?
> >
> > This way the numeric values for existing ones don't change.
>
> That's a concern if backpatching. Otherwise, it's better to put them
> like shown in the patch.
Agreed.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-05-27 12:45:57 | Re: pg_upgrade test writes to source directory |
| Previous Message | Amit Langote | 2022-05-27 12:22:34 | Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT |