From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Centralize json and jsonb handling of datetime types |
Date: | 2018-01-17 05:34:52 |
Message-ID: | CA+HiwqE4un9s7ebuQL9s4Qf1kSUT5mrCzsJqnOMv+-evLaqdrw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Jan 17, 2018 at 9:29 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Centralize json and jsonb handling of datetime types
[ ... ]
> src/include/utils/date.h | 4 +-
I noticed that these changes cause the following warning to be emitted
when compiling with gcc (GCC) 6.2.0:
In file included from gram.y:63:0:
../../../src/include/utils/date.h:76:41: warning: ‘struct pg_tm’
declared inside parameter list will not be visible outside of this
definition or declaration
extern int time2tm(TimeADT time, struct pg_tm *tm, fsec_t *fsec);
^~~~~
../../../src/include/utils/date.h:77:46: warning: ‘struct pg_tm’
declared inside parameter list will not be visible outside of this
definition or declaration
extern int timetz2tm(TimeTzADT *time, struct pg_tm *tm, fsec_t *fsec, int *tzp);
Attached is a fix.
Thanks,
Amit
Attachment | Content-Type | Size |
---|---|---|
cc4feded0a3-warning-fix.patch | application/octet-stream | 346 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Erik Rijkers | 2018-01-17 06:23:48 | Re: pgsql: Centralize json and jsonb handling of datetime types |
Previous Message | Andrew Dunstan | 2018-01-17 00:29:09 | pgsql: Centralize json and jsonb handling of datetime types |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2018-01-17 05:49:15 | Re: Rangejoin rebased |
Previous Message | Michael Paquier | 2018-01-17 04:51:06 | Re: TOAST table created for partitioned tables |