Re: [PATCH] Fix Null pointer dereferences (pgoutput.c)

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix Null pointer dereferences (pgoutput.c)
Date: 2020-04-23 15:48:42
Message-ID: CA+HiwqE47YCm8r8RH36ZzaQTArBEhQBfaDCXex03=hdxtsughA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 23, 2020 at 10:48 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Hi,
>
> Per Coverity.
>
> If test oldtuple can be NULL, I mean it can really be NULL.
> On DELETE process, if oldtuple is NULL, log error and continue.
> So UPDATE must have the same treatment.

I think I too had noticed this when working on my patch to move this
code to a different location in that function, posted here:
https://www.postgresql.org/message-id/CA%2BHiwqEeU19iQgjN6HF1HTPU0L5%2BJxyS5CmxaOVGNXBAfUY06Q%40mail.gmail.com

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-04-23 16:04:01 Re: Poll: are people okay with function/operator table redesign?
Previous Message Amit Langote 2020-04-23 15:39:11 Re: More efficient RI checks - take 2