makeAndExpr(), etc. confined to gram.y?

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: makeAndExpr(), etc. confined to gram.y?
Date: 2014-06-25 04:14:42
Message-ID: CA+HiwqE2fSsMZYm9VwBi4HaxSSoABHSu9kk9bqJUPug1u=4xTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

A recent commit titled "Avoid recursion when processing simple lists
of AND'ed or OR'ed clauses."
(2146f13408cdb85c738364fe8f7965209e08c6be) got rid of AEXPR_AND, etc.
and instead created makeAndExpr(), etc. in gram.y

Is there a reason why they've been left out of
makefuncs.h/makefuncs.c? Perhaps they are not supposed to be used
outside gram.y at all? For example, previously a caller (potentially)
outside parser could do a makeA_Expr(AEXPR_AND, ...). I guess this is
no longer possible with AEXPR_AND gone?

--
Amit

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-06-25 04:25:53 Re: [HACKERS] BUG #10728: json_to_recordset with nested json objects NULLs columns
Previous Message Stephen Frost 2014-06-25 04:10:55 Re: pgaudit - an auditing extension for PostgreSQL