Re: gram.y comment issue

On Wed, Mar 9, 2016 at 3:04 PM, 张文升 <wensheng(dot)zhang(at)qunar(dot)com> wrote:
> The gram.y includes the line(line:1965):
> /* ALTER TABLE <name> ALTER [COLUMN] <colname> SET ( column_parameter =
> value [, ... ] ) */
> ALTER opt_column ColId RESET reloptions
>
> The comment has the word "SET", but I think that's should be "RESET".

This one needs to be fixed.

> src/include/nodes/parsenodes.h line:141
> List *distinctClause; /* a list of SortGroupClause's */
> The comment has the word "SortGroupClause", but that's should be
> "distinctClause".

This one is fine. The name distinctClause here is parser's way of
referring to the SQL construct DISTINCT ON (<list-of-items>) in a
SELECT query, where each member of the list is a SortGroupClause item.

Thanks,
Amit