| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | yuzuko <yuzukohosoya(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: Autovacuum on partitioned table |
| Date: | 2020-02-20 08:32:40 |
| Message-ID: | CA+HiwqE=TjzwOhps8L5pQkMX7MbY0THZR5czcqCis3U27LwwwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 20, 2020 at 4:50 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> * I may be missing something, but why doesn't do_autovacuum() fetch a
> partitioned table's entry from pgstat instead of fetching that for
> individual children and adding? That is, why do we need to do the
> following:
>
> + /*
> + * If the relation is a partitioned table, we check it
> using reltuples
> + * added up childrens' and changes_since_analyze tracked
> by stats collector.
Oh, it's only adding up children's pg_class.reltuple, not pgstat
stats. We need to do that because a partitioned table's
pg_class.reltuples is always 0 and correctly so. Sorry for not
reading the patch properly.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-02-20 09:10:11 | Re: client-side fsync() error handling |
| Previous Message | asaba.takanori@fujitsu.com | 2020-02-20 08:29:35 | RE: Complete data erasure |