From: | Florin Irion <irionr(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | pg_create_logical_replication_slot argument incongruency |
Date: | 2022-09-19 17:02:16 |
Message-ID: | CA+HEvJDmFSKmqaXYuPNjkGpTboE35s_PifOg2AqwVJBn5rWGzw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
The function `pg_create_logical_replication_slot()` is documented to have
a `two_phase` argument(note the underscore), but the function instead
requires `twophase`.
```
\df pg_catalog.pg_create_logical_replication_slot
List of functions
-[ RECORD 1
]-------+---------------------------------------------------------------------------------------------------------------------------------
Schema | pg_catalog
Name | pg_create_logical_replication_slot
Result data type | record
Argument data types | slot_name name, plugin name, temporary boolean
DEFAULT false, twophase boolean DEFAULT false, OUT slot_name name, OUT lsn
pg_lsn
Type | func
```
This was introduced in commit 19890a06.
IMHO we should use the documented argument name `two_phase` and change the
function to accept it.
What do you think?
Please, check the attached patch.
Cheers,
Florin
--
*www.enterprisedb.com <http://www.enterprisedb.com/>*
Attachment | Content-Type | Size |
---|---|---|
two_phase_slot_v1.patch | application/octet-stream | 2.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2022-09-19 17:05:17 | Re: Kerberos delegation support in libpq and postgres_fdw |
Previous Message | Robert Haas | 2022-09-19 16:49:58 | Re: remove more archiving overhead |