Re: BUG #12989: pg_size_pretty with negative values

From: Christian Almeida <cbalmeida(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #12989: pg_size_pretty with negative values
Date: 2015-04-06 17:54:52
Message-ID: CA+EGHNCehGS-rKpLMB=CK=YEPcrZTmOcMWzOy=Pqse9Mv7MWYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Of course a file size will never be negative, but a size "delta" can be and
considering the function purpose, I think it should output "-118 MB".

Christian Almeida

2015-04-06 14:45 GMT-03:00 David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>:

> On Mon, Apr 6, 2015 at 10:30 AM, <cbalmeida(at)gmail(dot)com> wrote:
>
>> The following bug has been logged on the website:
>>
>> Bug reference: 12989
>> Logged by: Christian Almeida
>> Email address: cbalmeida(at)gmail(dot)com
>> PostgreSQL version: 9.3.6
>> Operating system: Ubuntu 14.04 LTS
>> Description:
>>
>> The function "pg_size_pretty" is not formatting negative numbers.
>>
>>
>> Example:
>> select pg_size_pretty(+123456789::bigint),
>> pg_size_pretty(-123456789::bigint)
>>
>> Output:
>> ----------------------------
>> 118 MB -123456789 bytes
>>
>>
> Do you want the result to be "-118 MB" or "ERROR: invalid input - size
> cannot be negative (-123456789)"?
>
> David J.
>

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2015-04-06 18:33:51 Re: BUG #12989: pg_size_pretty with negative values
Previous Message David G. Johnston 2015-04-06 17:45:41 Re: BUG #12989: pg_size_pretty with negative values

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2015-04-06 18:02:41 Re: TABLESAMPLE patch
Previous Message Jim Nasby 2015-04-06 17:51:56 Re: pg_dump / copy bugs with "big lines" ?