From: | Ants Aasma <ants(dot)aasma(at)eesti(dot)ee> |
---|---|
To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: Replication slot xmin is not reset if HS feedback is turned off while standby is shut down |
Date: | 2017-01-05 20:11:04 |
Message-ID: | CA+CSw_u14zXwnmwOYEgK9rBW3z-qmWgw20Bwac2KT7qG48s0XQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 5 Jan 2017 2:54 a.m., "Craig Ringer" <craig(at)2ndquadrant(dot)com> wrote:
On 2 January 2017 at 22:24, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>
>
> On 2 Jan. 2017 20:20, "Simon Riggs" <simon(at)2ndquadrant(dot)com> wrote:
>
> On 21 December 2016 at 13:23, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>
>> Fix it up and I'll commit. Thanks for the report.
>
> I was hoping for some more effort from Ants to correct this.
>
> I'll commit Craig's new tests for hs feedback before this, so it can
> go in with a Tap test, so I imagine we're about a week away from
> commit on this.
>
>
> I posted a revised version of Ants's patch that passes the shell script
> test.
>
> A TAP test would likely make sene though, I agree.
Ants, do you think you'll have a chance to convert your shell script
test into a TAP test in src/test/recovery?
Simon has said he would like to commit this fix. I'd personally be
happier if it had a test to go with it.
You could probably just add to src/test/recover/t/001 which now
contains my additions for hot standby.
I'm travelling right now, but I should be able to give it a shot next week.
Regards,
Ants Aasma
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2017-01-05 20:50:05 | Re: Replication/backup defaults |
Previous Message | Stephen Frost | 2017-01-05 20:04:36 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |