From: | Ants Aasma <ants(dot)aasma(at)eesti(dot)ee> |
---|---|
To: | Greg Stark <stark(at)mit(dot)edu> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Clean up the #include mess a little. |
Date: | 2011-09-06 15:40:04 |
Message-ID: | CA+CSw_swDoToduoEkt8GSi0dvMwDOYei--zATg_VrZedZpgZ1A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Sep 5, 2011 at 4:55 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
> What I wouldn't mind seeing is a graph of all includes and what they
> include. This might help figure out what layering violations there are
> like the one that caused this mess. I think I've seen tools to do this
> already somewhere.
I whipped together a quick Python script to do this. Attached is the
Python script (requires pydot) and the result of running it on includes/.
I didn't attach the png version of the output because it was 7MB.
If rendering all includes at once doesn't give a good overview it can
also select a subset through traversing dependencies. For example:
render_includes.py -i include/ \
--select="storage/spin.h+*,access/xlog.h+*" output.png
This will render everything that directly or indirectly depends on those
two headers. See --help for details.
--
Ants Aasma
Attachment | Content-Type | Size |
---|---|---|
pg_includes.svgz | image/svg+xml-compressed | 93.8 KB |
render_includes.py | text/x-python | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-09-06 16:16:37 | pgsql: Update type-conversion documentation for long-ago changes. |
Previous Message | Bruce Momjian | 2011-09-06 15:09:07 | pgsql: Properly document semphore requirements by accounting for worker |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-09-06 16:51:07 | Re: Redundant bitmap index scans on smallint column |
Previous Message | Tom Lane | 2011-09-06 15:19:45 | Re: Couple document fixes |