| From: | Ants Aasma <ants(at)cybertec(dot)at> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Missing pfree in logical_heap_rewrite_flush_mappings() |
| Date: | 2014-03-26 16:29:38 |
| Message-ID: | CA+CSw_sBGzgeG+gbwpTopAQdiuQuhHgewWjZQCR0Rb435Ps4OQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
It seems to me that when flushing logical mappings to disk, each
mapping file leaks the buffer used to pass the mappings to XLogInsert.
Also, it seems consistent to allocate that buffer in the RewriteState
memory context. Patch attached.
Regards,
Ants Aasma
--
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt
Web: http://www.postgresql-support.de
| Attachment | Content-Type | Size |
|---|---|---|
| missing-pfree-in-logical_heap_rewrite_flush_mappings.patch | text/x-patch | 741 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-03-26 16:47:25 | Re: small regression adjustment |
| Previous Message | Heikki Linnakangas | 2014-03-26 16:29:04 | Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG |