Accidental assignment instead of compare in GetOperatorFromCompareType?

From: Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Accidental assignment instead of compare in GetOperatorFromCompareType?
Date: 2025-03-03 05:05:47
Message-ID: CA+COZaC-JMbhQ4O0Q8V1Bxa0R+Nex_RN9D6UyuLPiEx_CK4Heg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an
equals sign in an ereport() in GetOperatorFromCompareType, giving the line:

cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator for
type %s", format_type_be(opcintype)) :

I think the impact is just that we'd never see the error messages for
the COMPARE_OVERLAP and COMPARE_CONTAINED_BY cases logged.

Regards,
Jacob

Attachment Content-Type Size
v01_fix_typos.patch application/octet-stream 5.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Brazeal 2025-03-03 05:06:18 Re: Accidental assignment instead of compare in GetOperatorFromCompareType?
Previous Message Michael Paquier 2025-03-03 04:13:05 Re: Add assertion for failed alloc to palloc0() and palloc_extended()