Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection

From: Heath Lord <heath(dot)lord(at)crunchydata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <jchampion(at)timescale(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
Date: 2022-09-29 20:21:59
Message-ID: CA+BEBhveaYJ0xoiUhSGmGdzEGs34rfPWZQyJ36vXHx0_Xt+dbA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Sep 29, 2022 at 4:16 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I wrote:
> > AFAICS that behavioral change is deliberate: for the single case
> > of inquiring about "library", PQsslAttribute now tells you which
> > SSL implementation libpq *can* use, not which one it's actually
> > using on a given connection. I'm not sure that this is a great
> > definition, since it's so unlike the behavior for other attributes.
>
> Actually, wait a minute: both the documentation and the commit
> message claim the new behavior is something different than what it
> actually is. The intention seems to have been to change the
> behavior only for the conn == NULL case. So maybe we need to
> fix it as attached. This'd still be broken for the
> multiple-libraries scenario, but I admit that that's pretty
> hypothetical.
>
> regards, tom lane
>
>
Tom,

I was in the process of drafting a reply, but this new patch seems to
resolve my issues with the documentation and functionality. I really
appreciate you looking into this and I am good with this patch.

Thanks,
Heath

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Daniel Gustafsson 2022-09-29 20:38:18 Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
Previous Message Tom Lane 2022-09-29 20:16:31 Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection