| From: | Mats Kindahl <mats(at)timescale(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-15 13:05:40 |
| Message-ID: | CA+14427und-7KT1kx33uUd0dJtXMpLNsUQ-SZPZUFG7G7+C2mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 14, 2024 at 5:13 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> On 14.11.24 15:35, Noah Misch wrote:
> > The postgr.es/c/e54a42a standard would have us stop here. But I'm open
> to
> > treating the standard as mistaken and changing things.
>
> That text explicitly calls out that adding struct members at the end of
> a struct is considered okay. But thinking about it now, even adding
> fields to the end of a node struct that extensions allocate using
> makeNode() is an ABI break that is liable to cause all affected
> extensions to break in a crashing way.
>
I think it was mentioned elsewhere, but this wouldn't be a problem if
makeNode was not a macro.
--
Best wishes,
Mats Kindahl, Timescale
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-11-15 13:12:49 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Mark Hill | 2024-11-15 13:01:36 | RE: FW: Building Postgres 17.0 with meson |