| From: | John H <johnhyvr(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow logical failover slots to wait on synchronous replication |
| Date: | 2024-08-26 19:31:53 |
| Message-ID: | CA+-JvFttvLPKo+B0kK8PZuWP+aVmuFaQK_6gmGKi4shhjyw6Ww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Bertrand,
On Sun, Jul 28, 2024 at 10:00 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> Yeah, at the same place as the static lsn[] declaration, something like:
>
> static XLogRecPtr lsn[NUM_SYNC_REP_WAIT_MODE]; /* cached LSNs */
>
> but that may just be a matter of taste.
>
I've updated the patch to reflect that.
>
> Right, we may want to cast it then but given that the for loop is "small" I think
> that's also fine to keep the for loop.
>
Ah I see what you mean. I've updated these changes and attached the
patch to the other thread.
Thanks,
--
John Hsu - Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-08-26 19:32:12 | Re: Proposal for Updating CRC32C with AVX-512 Algorithm. |
| Previous Message | Robert Haas | 2024-08-26 19:28:53 | Re: allowing extensions to control planner behavior |