| From: | Sravan Kumar <sravanvcybage(at)gmail(dot)com> | 
|---|---|
| To: | michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org | 
| Subject: | Compilation error after redesign of the archive modules | 
| Date: | 2023-03-10 08:11:07 | 
| Message-ID: | CA+=NbjguiQy-MbVqfQ-jQ=2Fcmx3Zs36OkKb-vjt28jMTG0OOg@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Hi,
    With the redesign of the archive modules:
35739b87dcfef9fc0186aca659f262746fecd778 - Redesign archive modules
   if we were to compile basic_archive module with USE_PGXS=1, we get
compilation error:
[]$ make USE_PGXS=1
gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -g -g -O0 -fPIC
-fvisibility=hidden -I. -I./
-I/home/sravanv/work/workspaces/PGdevel_test/include/postgresql/server
-I/home/sravanv/work/workspaces/PGdevel_test/include/postgresql/internal
 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o basic_archive.o
basic_archive.c -MMD -MP -MF .deps/basic_archive.Po
basic_archive.c:33:36: fatal error: archive/archive_module.h: No such
file or directory
 #include "archive/archive_module.h"
                                    ^
compilation terminated.
make: *** [basic_archive.o] Error 1
I have attached a patch that fixes the problem. Can you please review
if it makes sense to push this patch?
-- 
Thanks & Regards,
Sravan Velagandula
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size | 
|---|---|---|
| v1-0001-fix-archive-module-compilation-error.patch | application/octet-stream | 850 bytes | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-03-10 08:13:59 | Assert failure of the cross-check for nullingrels | 
| Previous Message | Julien Rouhaud | 2023-03-10 08:04:15 | Re: Combine pg_walinspect till_end_of_wal functions with others |