| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Add regression coverage for REVOKE ADMIN OPTION |
| Date: | 2021-11-16 14:31:18 |
| Message-ID: | C7F8FCB8-671E-476F-B606-C641E19AF4E0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 Nov 2021, at 00:58, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> While working on a fix for dangling references to dropped roles in the pg_auth_members.grantor field, I happened to notice we entirely lack regression test coverage of the REVOKE ADMIN OPTION FOR form of the RevokeRoleStmt. I am unaware of any bugs in the current implementation, but future work on roles may benefit if we close the testing gap.
LGTM. Reading this I realized that the GRANTED BY keyword for RevokeRoleStmt
isn't working as documented, it's not checking the role at all. I've sent a
diff for that with tests on the relevant thread, but I think it would be a good
to get this in too to boost coverage.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-11-16 14:32:15 | Re: Add regression coverage for REVOKE ADMIN OPTION |
| Previous Message | Daniel Gustafsson | 2021-11-16 14:27:25 | Re: Allow CURRENT_ROLE in GRANTED BY |