From: | "MauMau" <maumau307(at)gmail(dot)com> |
---|---|
To: | "Vik Fearing" <vik(dot)fearing(at)dalibo(dot)com>, "PG Docs" <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: pageinspect forks |
Date: | 2014-08-10 22:22:09 |
Message-ID: | C7973B036D05487FB1A83AA5231E2039@maumau |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
From: "Vik Fearing" <vik(dot)fearing(at)dalibo(dot)com>
> On 08/10/2014 03:24 PM, MauMau wrote:
>> Could you also improve the doc by changing "table" to "relation" in the
>> description of get_raw_page()? Having a quick look at the code, it
>> seems that the function can also handle indexes.
>>
>> table and returns a copy as a <type>bytea</> value. This allows a
>
>
> Good catch. I wasn't sure whether using "relation" or "table or index"
> was better, but after a quick test it seems it works for sequences, too,
> so I've gone with "relation".
>
> It doesn't work with views, of course, but it does work with
> materialized views.
>
> Modified patch attached.
Thanks, I marked this as ready for committer.
I think I'll leave it up to you to decide whether you improve the HINT
message Fujii-san pointed out, which is in src/backend/catalog/catalog.c.
Regards
MauMau
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2014-08-11 12:34:46 | Re: pageinspect forks |
Previous Message | Vik Fearing | 2014-08-10 18:59:59 | Re: pageinspect forks |