Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, byavuz81(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Date: 2022-02-08 15:28:36
Message-ID: C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 8 Feb 2022, at 01:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> * If I make my_sock_write ignore EPIPE/ECONNRESET, as per the
> attached entirely-uncommitable patch, the errors go away.

I can confirm that I wasn't able to reproduce the errors with the attached (and
the sleep() removed) running the tests over and over in a loop on Linux and
OpenBSD. Moreover, I was also unable to reproduce the error when only ignoring
EPIPE. When only ignoring ECONNRESET it worked intermittently on OpenBSD (but
all the time on Linux as expected).

> ..could we get away with ignoring EPIPE/ECONNRESET in writes during connection
> startup? We'd notice the failure soon enough on the read side if it's not this
> problem. (This seems a bit related to libpq's other hacks that postpone
> recognition of write failures.)

Off the cuff I can't think of a case where it would lead to adverse effects
*during startup*.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Marcia Almeida Rocha 2022-02-08 19:16:33 Package: postgresql14-contrib-14.1-1PGDG.rhel7.x86_64 (pgdg14) did not work with libpython3.7m.so.1.0
Previous Message Daniel Gustafsson 2022-02-08 14:16:44 Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0