Re: psql \e broken again

From: Travis P <twp(at)castle(dot)fastmail(dot)fm>
To: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql \e broken again
Date: 2004-11-15 14:50:55
Message-ID: C0C08E24-3715-11D9-B14F-003065F9DAF8@castle.fastmail.fm
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Sun, Nov 14, 2004 at 10:14:06PM -0500, Bruce Momjian wrote:
> John Hansen wrote:
>>>> 1. Quote only on Windows.
>>>>
>>>> 2. Expect user to put quotes in the EDITOR value if it contains a
>>>> space-containing path.
>>
>>
>> As far I I'm aware, the options on windows are very much like those on
>> unix:
>>
>> "path containing spaces" or
>> path\ containing\ spaces
>
> My guess is that we should only address spaces on Win32, but should
> document why did didn't do it on Unix. Also, what about OS X? Doesn't
> that have frequent spaces in file paths?

The underside of MacOS X is BSD-flavor Unix of course. For anyone
setting an environment variables, they are playing directly with that
layer. I'd recommend leaving it as you do for all Unix varieties and a
user can can quote or backslash-escape, just as he or she can on any
other Unix.

As precedent, other utilities, like 'find' don't to anything special
with the spaces, which can cause complications if you don't know to
anticipate dealing with that.

-Travis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-11-15 15:19:45 Re: GiST: PickSplit and multi-attr indexes
Previous Message Oleg Bartunov 2004-11-15 12:43:07 Re: GiST: PickSplit and multi-attr indexes